Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use console.warn instead of console.error when we catch a failed fetch #948

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Use console.warn instead of console.error when we catch a failed fetch #948

merged 2 commits into from
Dec 5, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 5, 2024

Tell Sentry these aren't as high a priority as other errors.

@eyeseast eyeseast requested a review from allanlasser December 5, 2024 15:10
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 3a161f0
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/6751c66a44d4900008b243d5
😎 Deploy Preview https://deploy-preview-948.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 26 (🔴 down 31 from production)
Accessibility: 86 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.03% 6820 / 21974
🔵 Statements 31.03% 6820 / 21974
🔵 Functions 49.19% 276 / 561
🔵 Branches 75.47% 1037 / 1374
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/api/accounts.ts 100% 100% 100% 100%
src/lib/api/addons.ts 67.94% 92% 64.28% 67.94% 79-184
src/lib/api/collaborators.ts 100% 100% 100% 100%
src/lib/api/documents.ts 91.5% 89.47% 96.96% 91.5% 89-108, 179-181, 186-187, 204-210, 516-518
src/lib/api/flatpages.ts 54.54% 50% 50% 54.54% 10-17, 29-30
src/lib/api/notes.ts 78.33% 84.61% 83.33% 78.33% 27-63
src/lib/api/projects.ts 87.3% 100% 86.66% 87.3% 101-105, 273-298
src/lib/api/sections.ts 58.26% 50% 60% 58.26% 17-67, 83-86, 118-121, 152-155
src/lib/api/tests/addons.test.ts 98.71% 95.74% 100% 98.71% 203-204, 235-236
src/lib/components/addons/AddOnPin.svelte 100% 0% 100% 100%
src/lib/components/addons/History.svelte 0% 0% 0% 0% 1-78
src/lib/components/addons/Scheduled.svelte 0% 0% 0% 0% 1-81
src/lib/components/documents/ResultsList.svelte 100% 28.57% 100% 100%
src/lib/components/processing/AddOns.svelte 0% 0% 0% 0% 1-166
src/lib/components/projects/ProjectPin.svelte 0% 0% 0% 0% 1-62
src/lib/components/viewer/PDF.svelte 0% 0% 0% 0% 1-842
src/lib/utils/api.ts 86.4% 80% 100% 86.4% 49-57, 104-106, 128-129, 132-133
src/lib/utils/scroll.ts 100% 100% 100% 100%
src/lib/utils/search.ts 82.92% 75% 75% 82.92% 15-16, 77-81
Generated in workflow #459 for commit 3a161f0 by the Vitest Coverage Report Action

@eyeseast eyeseast merged commit d871c60 into main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanlasser allanlasser allanlasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyeseast @allanlasser